Use merge queue on CI #2270
Open
Use merge queue on CI #2270
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's past time we configured a merge queue on this repo. Recently we ran into a case where two PRs were merged, which then results in a compile error and thus red tests on
master, because no CI was executed on both of those PRs at once.This PR:
deployworkflow. Deployment still happens from themasterbranch, not from the merge queue, which makes things a bit easier and won't require reconfiguring AWS's environment.When this is merged, the repository has to be reconfigured to use a merge queue.
Companion PR: rust-lang/team#2013